new help with errors on this code (c++)

rogue · 05-11-2005, 11:04 AM

ok i have been making a rainfall code to show town,country, and rainfall. i got most of it but i am having problems with the strings the error keep coming up about adding two pointers.could someone please look at this and tell me what i have wrong without changing the statement too much.
Thank you

~VALerie

Code:

/*Rainfall*/
#include <stdio.h>
#include <string.h>
#include <stdlib.h>
#include <conio.h>

/*function protoypes*/

FILE *datain;

void CloseFiles(void);
void TownFooter(void);
void CtryFooter(void);
void NewTownBreak(void);
void NewCtryBreak(void);

/*define and initialize variables*/
char Ctry[10],	prevCtry[10];
char Town[10],	prevTown[10];
int rainfall, stotTown, stotCtry;



/* MAIN PROGRAM */

void main()
{
	if ((datain = fopen("e:\\rainfall.txt","r"))== NULL)
	{
		printf("Cannot open file");
		exit(1);
	}
	system("cls");
	printf("\nAnnual Rainfall by Town / Country");
	printf("\nTown     Country    Inches");
	printf("\n******************************************************");
	fscanf(datain, "\n%s\n%s\n%d",prevCtry,prevTown);
	strcpy(prevCtry, Ctry);    
	strcpy(prevTown, Town);
	printf("\nData for the Country of %s", Ctry);
	while (strcmp(Town,"prevTown"))
	{
	   stotTown = prevTown+Town
	   stotCtry = prevCtry+Ctry
	   gtotal = stotTown+stotCtry
		prinf("%s %s %d", Town, Ctry, rainfall);

	   fscanf(datain, "\n%s\n%s\n%d", stotTown,stotCtry);
	   
	   if (strcmp(prevCtry) && strcmp(Ctry,"xxxx"))
	   {
			NewCtryBreak();
	   }
	   else if (strcmp(prevTown) && strcmp(Town, "xxxx"))
	   {
			NewTownBreak();
	   }
	}
	printf("\n Subtotal for %s %s = %d",prevTown, prevCtry, stotTown);
	printf("\n\n Subtotal for %s = %d", prevCtry, stotCtry);
	printf("\n******************************************************");
	printf("\n\nGrandtotal = %d", gtotal);
   }

	void NewCtryBreak(void)
	{
	  TownFooter();
	  CtryFooter();
	   printf("\nData for the Country of %s\n\n", Ctry);
	}

	void NewTownBreak(void)
	{
		 TownFooter();
	}

	void CtryFooter(void)
	{
	  printf("\n\n Subtotal for %s = %d", prevCtry, stotCtry);
	  printf("\n******************************************************\n");
	   stotCtry = prevCtry+Ctry;
	   strcpy(Ctry);
	}

	void TownFooter(void)
	{
	   printf("\n Subtotal for %s %s = %d",prevTown, prevCtry, stotTown);
	   stotTown = prevTown+Town;
	   strcpy(Town);
	}

Valmont · 05-11-2005, 11:58 AM

I believe I told you before to read the link below before posting anything:
[READ THIS FIRST] About the standard C++ forum.

redhead · 05-11-2005, 10:47 PM

Code:

05: #include <conio.h>

This is not a system independant header, and it is not needed in this program.

Code:

26:void main()

Please use int main(), it is more polite, any compiler will turn void main() in to int main() anyway..

Code:

33:  system("cls");

Tsk, tsk, tsk.. very not system independant to use a system call..

Code:

37:  fscanf(datain, "\n%s\n%s\n%d",prevCtry,prevTown);

Why search for 3 inputs and only use two, why reference the variables as parse by value, instead of the needed parse by reference..

Code:

44:              stotCtry = prevCtry+Ctry

how do you expect the char* to know anything about a + operator, your code is in C, yet you try and use varius C++ like features.

Code:

48: fscanf(datain, "\n%s\n%s\n%d", stotTown,stotCtry);

Again, you're one argument short, and you are trying to store strings (char*) into int types, another thing, when using the *scanf() functions, you have to be sure you've alocated the space needed, else your program will end up with unexplainable errors.

Code:

50:   if (strcmp(prevCtry) && strcmp(Ctry,"xxxx"))
51:           {
52:             NewCtryBreak();
53:           }
54:         else if (strcmp(prevTown) && strcmp(Town, "xxxx"))

You do realize strcmp() needs atleast two arguments.. both beeing const char* since we are picky here, it is better to use strncmp() since you're second argument is of a specific length.

Code:

62:  printf("\n\nGrandtotal = %d", gtotal);

gtotal was never declared, or calculated or anything...

Code:

81:  stotCtry = prevCtry+Ctry;
82:  strcpy(Ctry);

Again, prevCtry beeing of char* (and thats enough I dont even have to know what type Ctry is) has no refference of any + operator, and strcpy() needs two arguments, the storage pointer, and the intended filling to copy to it..

Code:

88:  stotTown = prevTown+Town;
89:  strcpy(Town);

Read my above description with sed 's/Ctry/Town/g'

rogue · 05-14-2005, 05:48 PM

Thanks red. I appreciate you trying to help me understand it . i got a better concept now. I hope to not have to use these posts again.