do-while loop

[M3GAPL3X]

Hi all,

I was just doing some basic looping in C++ and I can't seem to compile this program. It keeps giving me a:
"syntax error : '}'

I have taking } out and still doesn't seem to compile. If anyone could help, it would be greatly appreciated! Thanks in advance!

Here is the code. I am using the Visual C++ compiler.

/*
OUTPUT (MENU) à INPUT à SHOWINFO. à LOOP PROGRAM à END IF USER PRESSES >=6
*/

// Define the header file used in this program. 
#include <iostream.h>

int main()
{
	// Declare the selection variable
	int selectop;

	// Show the menu
	cout << "\t\t\t\tProgram About ME" << endl;
	cout << "\t\t\t\t----------------" << endl;
	cout << "\nClick appropriate number to view information" << endl;
	cout << "\n\n1. My Full Name " << endl;
	cout << "2. My Brother's and Sister's Name " << endl;
	cout << "3. My City and Country of Birth " << endl;
	cout << "4. My Favorite Book Title " << endl;
	cout << "5. My Favorite Movie " << endl;
	cout << "6. Exit the program " << endl;

	selectop = 1;

	do
	{
		switch(selectop)
		{
		case 1:
			cout << "My name is Menish Sharma " << endl;
			break;
	
		case 2:
			cout << "Unfortunately, I don't have a brother or sister. " << endl;
			break;

		case 3:
			cout << "I was born in Sacramento, California which is in the U.S. " << endl;
			break;

		case 4:
			cout << "My favorite book is Great Expectations. " << endl;
			break;
			
		case 5:
			cout << "My favorite movie is the Shawshank Redemption. " << endl;
			break;

		case 6:
			cout << "Exiting my program. " << endl;
break;

		default:
			cout << "The number " << selectop << " is not valid in this program. Please try again: ";
			break;

			return 0;
		}
		while (selectop <=6);
	}
}

[joe_bruin]

your "while" should not be inside your "do" block.

do
{
  // something
} while(a == 1);

[M3GAPL3X]

Thanks a lot joe_bruin!
Now I have to figure out how to make this program not loop forever!!

Thanks again.

[ender]

Your problem lies in the fact that your test will only exit if you hit 7 or higher. This is due to the fact that <= says 'while it is less than or equal to 6, it is true." However, as your 'exit' happens ON six, you have to have 6 be an exit condition, so your loop should be something like:

do {
     // Some code
} while (someVar < 6);

Sorry if this sounds belittling, I didn't mean it to. Hope this helps.

Ted

[M3GAPL3X]

Thanks ender, I'll be sure to get that down next time!