csv file to mysql using php

[jayteema]

I am using a very common script to insert a csv file

<?
# first get a mysql connection as per the FAQ

$DBhost = "localhost";
$DBuser = "DBuser";
$DBpass = "DBpass";
$DBName = "DBName";
$table = "table";
mysql_connect($DBhost,$DBuser,$DBpass,$DBName) or die("Unable to connect to database");

$fcontents = file ('./topscsv.csv');
# expects the csv file to be in the same dir as this script

for($i=0; $i<sizeof($fcontents); $i++) {
$line = trim($fcontents[$i]);
$arr = explode(",", $line);
#if your data is comma separated
# instead of tab separated,
# change the '\t' above to ','

$sql = "insert into $table values ('".
implode("','", $arr) ."')";
mysql_query($sql);
echo $sql ."<br>\n";
if(mysql_error()) {
echo mysql_error() ."<br>\n";
}
}

?>

It echos the data fine, but every other line says

No Database Selected

I am sure it is something stupid, but I can't by this issue

Thanks for your help

Jayteema

[sde]

you need to select a db after you connect: http://www.php.net/manual/en/functio...-select-db.php

PHP Code:

<?php

$link = mysql_connect('localhost', 'mysql_user', 'mysql_password');
if (!$link) {
   die('Not connected : ' . mysql_error());
}

// make foo the current db
$db_selected = mysql_select_db('foo', $link);
if (!$db_selected) {
   die ('Can\'t use foo : ' . mysql_error());
}
?>

[jayteema]

Thanks for the quick Reply!

[jayteema]

I am getting a parse error now \\Can anyone see an issue

Thanks for your help

PHP Code:

<?
   # first get a mysql connection as per the FAQ


$link = mysql_connect('localhost', 'topselec_jt', 'bucket'); 

if (!$link) { 
   die('Not connected : ' . mysql_error()); 
} 

// make foo the current db 
$db_selected = mysql_select_db('topselec_data', $link); 
if (!$db_selected) { 
   die ('Can't use foo : ' . mysql_error()); 
} 




  $fcontents = file ('./topscsv.csv'); 
  # expects the csv file to be in the same dir as this script

  for($i=0; $i<sizeof($fcontents); $i++) { 
      $line = trim($fcontents[$i]); 
      $arr = explode(",", $line); 
      #if your data is comma separated
      # instead of tab separated, 
      # change the 't' above to ',' 
     
      $sql = "insert into $table values ('". 
                  implode("','", $arr) .")"; 
      mysql_query($sql);
      echo $sql ."<br>n";
      if(mysql_error()) {
         echo mysql_error() ."<br>n";
      } 
}

?>

[sde]

when you are getting parse errors, please report the line that the error is happening on. it makes helping you much easier ..

just from looking at it, i say it's your first comment

PHP Code:

# first get a mysql connection as per the FAQ 


'#' is not a comment character in php.. use '//'

PHP Code:

// first get a mysql connection as per the FAQ 


[sde]

on, and now i see you have a LOT of those style comments .. change them all to //

[idx]

I believe # is a valid comment character ( http://www.php.net/manual/en/languag...x.comments.php ), but // seems to be the preferred style for one-liners.

Here's your parse error:

die ('Can't use foo : ' . mysql_error());

You need to escape the quote in can't .

-r

[sde]

cool, i've never seen that before. nice catch.

[JeC]

I noticed the parse error just with this boards PHP code highlighting. The 2nd half of the code is all red - that's not right.

[jayteema]

Any help would be appreciated on how to see what JeC is looking at?

Thanks
Jim

[sde]

he's just referring to the highlighting.. not really anything to do with your script. ( i think )

this board is just using the built in php highlighting function. nothing custom really.