MYSQL - insert

[jimmyoctane]

I am modifing a script I borrowed and am trying to get info
from the visitor to my site.

I have it so I can display the data to the screen but would like to write to mysql database :

================================================== ================
$browser = $client->property('browser');
$longname = $client->property('long_name');
$version = $client->property('version');
$javascript = $client->property('javascript');
$platform = $client->property('platform');
$os = $client->property('os');
$ip = $client->property('ip');
$language = $client->property('language');


//$mysqlinsert = mysql_query("INSERT INTO userlog VALUES("$browser", "$longname", "$version", "$javascript", "$platform", "$os", "$ip", "language" ");

print $browser;
print $longname;
print $version;
print $javascript;
print $platform;
print $os;
print $ip;
print $language;

?>
================================================== ================
not sure how to do the INSERT part only been at this a couple of days

[Belisarius]

I'm not really familiar with PHP, but was wondering if PHP was smart enough to tell that an identifier beginning with a '$' inside a quote was a variable rather than a literal?

At any rate, you have missmatched parens, and I'm willing to bet that your quotes are missmatched as well. And it looks like you forgot a '$' in front of 'language'.

[jimmyoctane]

The "$" is missing from variable and you are right that the data in double quotes is seen as a char value instead of actual field value....but I think that doesnt matter at this point. The data should still be written to the database.
The record would look like this:

database: userlog
field: Browser = "$browser"
field: longname = "$longname"
field: version = "$version"
field: javascript = "$javascript"
field: platform = "$platform"
field: os = "$os"
field: ip = "$ip"
field: language = "language"







Just unsure of syntax.

I just pulled this section of code out of a much larger program.



Thanks for the reply
database: userlog

[jimmyoctane]

Okay I got it

here goes

$query = "INSERT INTO userlog ( browser , long_name , version , javascript ,
platform , os , ip , language ) VALUES ('$browser', '$longname', '$version',
'$javascript', '$platform', '$os', '$ip', '$language' )";

$result = mysql_query($query);


thanks

[Belisarius]

I think you still have the quoting problem. Here's how I would do it (again, I'm not familiar with PHP).

$query = "INSERT INTO userlog (browser, long_name, version, javascript, platform, os, ip, language) VALUES ('" + $browser + "','" + $longname + "','" + $version + "','" + $javascript + "','" + $platform + "','" + $os + "','" + $ip + "','" + $language + "')";

You need to escape out of the quote for each variable.

[sde]

while it may be good practice, php doesn't require you to isolate the variables like that .. ( except in certain instances like when your using objects )

also, when you are isolating variables, php uses '.' not '+'

so your query string would look like this:

PHP Code:

<?
$query = "INSERT INTO userlog (browser, long_name, version, javascript, platform, os, ip, language) 
     VALUES ('" . $browser . "','" . $longname . "','" . $version . "','" . $javascript . "','" . $platform . "','" . $os . "','" . $ip . "','" . $language . "')";
?>

but jimmy's way will work fine too =)

[Belisarius]

Grrr, non-#!@$-C syntax.

[sde]

i know .. i go between php and c# a lot and will mix up my . and + once in a while.