If statements

[abc123]

i've just figured something out and i'm starting to use it but im not sure if it is really good coding style...

e.g.

//my if statements used to look like this

public void stuff()
{
	if(abc)
	{
		doSomething(x);
	}
	else
	{
		doSomething(y);
	}
}


//but now they look like this

public void stuff2()
{
	if(abc)
	{
		doSomething(x);
		return;
	}
	
	doSomething(y);
}

is this a good idea? doesn't matter? or should I stick to the regular if/else situation.

[technobard]

Personally, I prefer the if/else structure. It's clearer (not that the other one is a stretch). It makes a bigger difference on a method that returns something. For example:

public boolean checkit () {
   boolean stat = false;

   if (abc) {
      doSomething(x);
      stat = true;
   } else {
      doSomething(y);
      stat = false;  //the default, so not really necessary
   }

   return stat;
}

Opinions will probably vary on this one, but I like having a single return where possible. (Although I'm sure I've violated this in some of my code).

[abc123]

Yeah, thats the way I used to like to do it but I found that the other way is pretty useful instead of putting huge if/else's around your code, saved me heaps of time and confusing

if(cantContinue) error("whatever"); return;

rather than

if(!cantContinue)
{
  //do things
}
else
{
  //stop
  error("whatever");
}

[sde]

i have wondered the same thing in php, but i decided to code the long way because it's easier to read.

i'm not using your exact example, but something more like this:

PHP Code:

<?
// short way
if($i == 1) echo "i is 1";

// long way
if($i == 1)
{
  echo "i is 1";
}
?>

just seams like it would take less time debugging if things went wrong.

[sde]

does java support the ternary operator?

it is something i learned in c++, and recently learned that php supports

PHP Code:

<?
($i == 1) ? ($x = "i is 1") : ($x = "i is not 1");
?>

$first ? $second : $third

above is the format.. if $first is true, then execute the $second expression, else execute the $third expression.

[abc123]

I'm more referring to the fact that you can just "return" from a function thereby not needing the "else" part because your program will never get there if it "returns" prior.

e.g.

private void x()
{
 a();
 b();
 return;
 c();
}

gives a "Error, unreachable statement" at "c()" in java at least, im not sure if php supports it but i think it would from what i've seen.

i usually prefer the "long way" you're referring to as well and the way i'm suggesting would make it a little weird to read for debugging but i think it saves heaps of time, for me at least.

[sde]

aah, i do get it now..

that is pretty good .. sorry to keep referrencing php, but that is the only thing i can test quickly and know well =)

PHP Code:

<?
function test()
{
    $i=1;    
    if($i==1) return 1;
    
    return 0;
}

printf(test());
?>

i didn't realize it would exit out of the code after a return. cool, thanks!

[sdeming]

As technobard said, opinions on this will vary. My opinion is to get out of the function ASAP and have as few indented code blocks as possible. As a general rule (not enforced) we like to refactor (factor-out) our code any time we we nest more than two code blocks, and one way to do this is to short-circuit the function and return eliminating the need for an else.

[kenshi]

It's all about preference. The first method is easier to read (to most people) and is more of a standard. The second method is probably slightly faster. (You'd have to pass through that bit of code thousands of times per second just for it to be slightly noticeable even on a 486 though.) I'd say use the second choice on your own programs if you like it better, but if you're going to get people to help you code, or you're doing it for a business, go with the first.